-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linuxWaitFd: make NetworkSubsystemFailed error unreachable #6827
Conversation
Rebased PR on top of master to hopefully fix spurious CI failures. |
The macOS build keeps failing in a test which seems to be comparing some translate-c output, but I'm not sure how to even read/diagnose the build output. Seems to be completely unrelated to this PR though. |
It's the pinned issue: #6830 Been trying to figure it out all day, sorry about that. |
Thanks for the heads up! Note to self: Read the actual pinned issues when something fishy seems to be going on! 😄 |
Rebased PR on top of master once more now that #6830 is fixed. |
This error from os.poll is Windows-specific, so unreachable on Linux.
Since the #6600 proposal to get rid of/rework |
I think your change is a nice improvement in the meantime :) |
This error from os.poll is Windows-specific, so unreachable on Linux.
Closes #6794